Skip to content

gh-116742 : Fix assertIn check with [None, b'BDFL'] as values for stdout#116917

Closed
JitendraPrabhu-l wants to merge 2 commits into
python:mainfrom
JitendraPrabhu-l:test_check_output_timeout
Closed

gh-116742 : Fix assertIn check with [None, b'BDFL'] as values for stdout#116917
JitendraPrabhu-l wants to merge 2 commits into
python:mainfrom
JitendraPrabhu-l:test_check_output_timeout

Conversation

@JitendraPrabhu-l

@JitendraPrabhu-l JitendraPrabhu-l commented Mar 16, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown

@ghost

ghost commented Mar 16, 2024 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app Bot mentioned this pull request Mar 16, 2024
Closed
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Mar 16, 2024
@bedevere-app

bedevere-app Bot commented Mar 16, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@JitendraPrabhu-l

JitendraPrabhu-l commented Mar 16, 2024

Copy link
Copy Markdown
Author

sobolevn
sobolevn requested changes Mar 16, 2024
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #116742 (comment)

@bedevere-app

bedevere-app Bot commented Mar 16, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@sobolevn sobolevn closed this Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn requested changes
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees

No one assigned

Labels

awaiting changes tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JitendraPrabhu-l @sobolevn